Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change structure of Callbacks #210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change structure of Callbacks #210

wants to merge 4 commits into from
+17 −13

Conversation

cremertim
Copy link
Contributor

@cremertim cremertim commented Mar 3, 2025 •
edited by coderabbitai bot
Loading

Bugfix to the new structure of the Artemis URLs (ls1intum/Artemis#10416)

Summary by CodeRabbit

  • Chores
    • Revised internal routing for status updates to enhance the reliability and consistency of backend communications.
    • Updated API endpoint paths for various status callback classes to improve integration with the backend.
    • This update optimizes system performance and lays the groundwork for future enhancements without affecting user-facing functionality, reinforcing our commitment to continuous system improvement.

@cremertim cremertim requested a review from bassner as a code owner March 3, 2025 22:58
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2025 •
edited
Loading

Walkthrough

The changes in this pull request involve updating the construction of API endpoint URLs across several callback classes. The base URL has been modified from "/api/public/pyris/... to "/api/iris/public/pyris/... in the constructors of multiple classes, including CourseChatStatusCallback, ExerciseChatStatusCallback, and others. Similar updates were made in the FaqIngestionStatus, IngestionStatusCallback, and LecturesDeletionStatusCallback classes. No other logic or exported interface signatures were altered.

Changes

File(s) Change Summary
app/.../status/status_update.py Updated URL construction in multiple callback classes (CourseChatStatusCallback, ExerciseChatStatusCallback, ChatGPTWrapperStatusCallback, TextExerciseChatCallback, CompetencyExtractionCallback, RewritingCallback, InconsistencyCheckCallback, LectureChatCallback) to use the new base URL "/api/iris/public/pyris/pipelines/..." instead of "/api/public/pyris/pipelines/...".
app/.../status/faq_ingestion_status_callback.py Updated URL in FaqIngestionStatus class from /api/public/pyris/webhooks/ingestion/faqs/runs/{run_id}/status to /api/iris/public/pyris/webhooks/ingestion/faqs/runs/{run_id}/status.
app/.../status/ingestion_status_callback.py Updated URL in IngestionStatusCallback class from f"{base_url}/api/public/pyris/webhooks/ingestion/runs/{run_id}/status" to f"{base_url}/api/iris/public/pyris/webhooks/ingestion/runs/{run_id}/status".
app/.../status/lecture_deletion_status_callback.py Updated URL in LecturesDeletionStatusCallback class from "{base_url}/api/public/pyris/webhooks/ingestion/runs/{run_id}/status" to "{base_url}/api/iris/public/pyris/webhooks/ingestion/runs/{run_id}/status".

Suggested labels

component:Pipeline, component:Domain

Suggested reviewers

  • MichaelOwenDyer
  • kaancayli
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e00e6e0 and 119746b.

📒 Files selected for processing (3)
  • app/web/status/faq_ingestion_status_callback.py (1 hunks)
  • app/web/status/ingestion_status_callback.py (1 hunks)
  • app/web/status/lecture_deletion_status_callback.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Push Docker Image
🔇 Additional comments (3)
app/web/status/lecture_deletion_status_callback.py (1)

20-22: URL endpoint path updated to match new Artemis API structure

The change correctly updates the API endpoint path from /api/public/pyris/... to /api/iris/public/pyris/... to align with the new structure of Artemis URLs referenced in the PR description.

app/web/status/ingestion_status_callback.py (1)

24-26: URL endpoint path updated to match new Artemis API structure

The change correctly updates the API endpoint path from /api/public/pyris/... to /api/iris/public/pyris/... to align with the new structure of Artemis URLs referenced in the PR description.

app/web/status/faq_ingestion_status_callback.py (1)

24-24: URL endpoint path updated to match new Artemis API structure

The change correctly updates the API endpoint path from /api/public/pyris/... to /api/iris/public/pyris/... to align with the new structure of Artemis URLs referenced in the PR description.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sorry, something went wrong.

coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 3, 2025
View reviewed changes
@cremertim
black
Loading
Loading status checks…
e00e6e0
coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 4, 2025
View reviewed changes
@cremertim
another URL fix
Loading
Loading status checks…
3d577c5
@cremertim
Run black
Loading
Loading status checks…
119746b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot]

@bassner bassner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:FastAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cremertim